lkml.org 
[lkml]   [2023]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] drm/panel/panel-tpo-tpg110: fix a possible null pointer dereference
On 07/10/2023 05:03, Ma Ke wrote:
> In radeon_fp_native_mode(), the return value of drm_mode_duplicate()

Wrong function, it should be tpg110_get_modes()

Thanks,
Neil

> is assigned to mode, which will lead to a NULL pointer dereference
> on failure of drm_mode_duplicate(). Add a check to avoid npd.
>
> Signed-off-by: Ma Ke <make_ruc2021@163.com>
> ---
> drivers/gpu/drm/panel/panel-tpo-tpg110.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-tpo-tpg110.c b/drivers/gpu/drm/panel/panel-tpo-tpg110.c
> index 845304435e23..f6a212e542cb 100644
> --- a/drivers/gpu/drm/panel/panel-tpo-tpg110.c
> +++ b/drivers/gpu/drm/panel/panel-tpo-tpg110.c
> @@ -379,6 +379,8 @@ static int tpg110_get_modes(struct drm_panel *panel,
> connector->display_info.bus_flags = tpg->panel_mode->bus_flags;
>
> mode = drm_mode_duplicate(connector->dev, &tpg->panel_mode->mode);
> + if (!mode)
> + return -ENOMEM;
> drm_mode_set_name(mode);
> mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED;
>

\
 
 \ /
  Last update: 2023-10-09 10:56    [W:2.577 / U:0.736 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site