Messages in this thread Patch in this message | | | Date | Mon, 9 Oct 2023 11:39:09 -0700 | Subject | [PATCH v3 07/18] perf jitdump: Avoid memory leak | From | Ian Rogers <> |
| |
jit_repipe_unwinding_info is called in a loop by jit_process_dump, avoid leaking unwinding_data by free-ing before overwriting. Error detected by clang-tidy.
Signed-off-by: Ian Rogers <irogers@google.com> --- tools/perf/util/jitdump.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/tools/perf/util/jitdump.c b/tools/perf/util/jitdump.c index 6b2b96c16ccd..1f657ef8975f 100644 --- a/tools/perf/util/jitdump.c +++ b/tools/perf/util/jitdump.c @@ -675,6 +675,7 @@ jit_repipe_unwinding_info(struct jit_buf_desc *jd, union jr_entry *jr) jd->eh_frame_hdr_size = jr->unwinding.eh_frame_hdr_size; jd->unwinding_size = jr->unwinding.unwinding_size; jd->unwinding_mapped_size = jr->unwinding.mapped_size; + free(jd->unwinding_data); jd->unwinding_data = unwinding_data; return 0; -- 2.42.0.609.gbb76f46606-goog
| |