Messages in this thread | | | Date | Mon, 9 Oct 2023 11:30:13 -0700 | From | Kees Cook <> | Subject | Re: [PATCH] net: dsa: lantiq_gswip: replace deprecated strncpy with ethtool_sprintf |
| |
On Mon, Oct 09, 2023 at 06:24:20PM +0000, Justin Stitt wrote: > `strncpy` is deprecated for use on NUL-terminated destination strings > [1] and as such we should prefer more robust and less ambiguous string > interfaces. > > ethtool_sprintf() is designed specifically for get_strings() usage. > Let's replace strncpy in favor of this more robust and easier to > understand interface. > > Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1] > Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2] > Link: https://github.com/KSPP/linux/issues/90 > Cc: linux-hardening@vger.kernel.org > Signed-off-by: Justin Stitt <justinstitt@google.com>
Looks like the expected replacement. Thanks!
Reviewed-by: Kees Cook <keescook@chromium.org>
-- Kees Cook
| |