Messages in this thread | | | Date | Mon, 9 Oct 2023 19:20:36 +0100 | From | Lorenzo Stoakes <> | Subject | Re: [PATCH 2/4] mm: make vma_merge() and split_vma() internal |
| |
On Mon, Oct 09, 2023 at 05:45:26PM +0200, Vlastimil Babka wrote: > On 10/8/23 22:23, Lorenzo Stoakes wrote: > > Now the vma_merge()/split_vma() pattern has been abstracted, we use it > > "it" refers to split_vma() only so "the latter" or "split_vma()"? >
I mean to say the pattern of attempting vma_merge(), then if that fails, splitting as necessary. I will try to clarify the language in v2.
> > entirely internally within mm/mmap.c, so make the function static. We also > > no longer need vma_merge() anywhere else except mm/mremap.c, so make it > > internal. > > > > In addition, the split_vma() nommu variant also need not be exported. > > > > Signed-off-by: Lorenzo Stoakes <lstoakes@gmail.com> > > Reviewed-by: Vlastimil Babka <vbabka@suse.cz> >
Thanks!
| |