Messages in this thread | | | Date | Fri, 6 Jan 2023 15:04:20 -0800 | From | Mike Kravetz <> | Subject | Re: [PATCH mm-unstable 1/8] mm/hugetlb: convert isolate_hugetlb to folios |
| |
On 01/03/23 13:13, Sidhartha Kumar wrote: > Convert isolate_hugetlb() to take in a folio and convert its callers to > pass a folio. Using page_folio() to convert the callers to use a folio is > safe as isolate_hugetlb() operates on a head page. > > Also add a folio equivalent of get_page_unless_zero(). > > Signed-off-by: Sidhartha Kumar <sidhartha.kumar@oracle.com> > --- > include/linux/hugetlb.h | 4 ++-- > include/linux/mm.h | 5 +++++ > mm/gup.c | 2 +- > mm/hugetlb.c | 16 ++++++++-------- > mm/memory-failure.c | 2 +- > mm/memory_hotplug.c | 2 +- > mm/mempolicy.c | 2 +- > mm/migrate.c | 2 +- > 8 files changed, 20 insertions(+), 15 deletions(-)
The hugetlb parts look fine to me. If you address the get_folio_unless_zero issue pointed out by Matthew,
Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com> -- Mike Kravetz
| |