Messages in this thread | | | Date | Fri, 6 Jan 2023 12:29:00 -0800 | From | Ashok Raj <> | Subject | Re: [PATCH v3 3/6] x86/microcode: Display revisions only when update is successful |
| |
On Fri, Jan 06, 2023 at 08:54:30PM +0100, Borislav Petkov wrote: > On Fri, Jan 06, 2023 at 11:42:32AM -0800, Ashok Raj wrote: > > > 9bd681251b7c ("x86/microcode: Announce reload operation's completion") > > > > Thanks.. yes I can add when I resent the series. > > No, you should read the commit message: > > "issue a single line to dmesg after the reload ... to let the user know that a > reload has at least been attempted." > > and drop your patch. > > We issue that line unconditionally to give feedback to the user that the attempt > was actually tried. Otherwise, you don't get any feedback and you wonder whether > it is doing anything. > > The prev and next revision: > > "microcode revision: 0x%x -> 0x%x\n", > > will tell you whether something got loaded or not.
Yes, that makes sense, Do you think we can add a note that the loading failed? since the old -> new, new is coming from new microcode rev.
Reload failed/completed ?
| |