Messages in this thread | | | Date | Fri, 6 Jan 2023 08:16:56 +0100 | From | Jiri Slaby <> | Subject | Re: [PATCH v6] serial: linflexuart: Remove redundant uart type assignment |
| |
On 05. 01. 23, 18:04, 李哲 wrote: > in linflex_config_port() the member variable type will be > assigned again. see linflex_connfig_port()
I wrote to v5: Please use capitals when you start a sentence. And periods at the ends of them.
> Signed-off-by: 李哲 <sensor1010@163.com>
> V4 -> V5: Link: https://lore.kernel.org/all/ddcf396b-7b91-00f3-8c16-7de5dc891aef@kernel.org/ > V3 -> V4: Link: https://lore.kernel.org/all/2f726128-29c-b7dd-ad8-f8b536fbe5f@linux.intel.com/ > V2 -> V3: Link: https://lore.kernel.org/all/8f433e5-fb46-d3b8-431b-4bddcc938f6b@linux.intel.com/ > V1 -> V2: Link: https://lore.kernel.org/all/1c33a2af-cd0d-cdde-5bc7-49b418665784@kernel.org/
This is not the proper way. PLease see: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-canonical-patch-format
> --- > drivers/tty/serial/fsl_linflexuart.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/tty/serial/fsl_linflexuart.c b/drivers/tty/serial/fsl_linflexuart.c > index 6fc21b6684e6..34400cc6ac7f 100644 > --- a/drivers/tty/serial/fsl_linflexuart.c > +++ b/drivers/tty/serial/fsl_linflexuart.c > @@ -837,7 +837,6 @@ static int linflex_probe(struct platform_device *pdev) > return PTR_ERR(sport->membase); > > sport->dev = &pdev->dev; > - sport->type = PORT_LINFLEXUART; > sport->iotype = UPIO_MEM; > sport->irq = platform_get_irq(pdev, 0); > sport->ops = &linflex_pops;
-- js suse labs
| |