Messages in this thread | | | Date | Fri, 6 Jan 2023 16:34:23 +0000 | From | Mark Brown <> | Subject | Re: [PATCH v2 1/2] spi: spidev: fix a race condition when accessing spidev->spi |
| |
On Fri, Jan 06, 2023 at 05:27:34PM +0100, Bartosz Golaszewski wrote: > On Fri, Jan 6, 2023 at 5:16 PM Mark Brown <broonie@kernel.org> wrote:
> > The complication is using a semaphore at all, it's a pretty unusual > > locking construct and the whole up/down thing isn't clear to people > > who aren't familiar with it. Given that there's no clounting being > > used rwlock would be a much more obvious choice if the microseconds > > of extra concurrency is meaningful somehow.
> I don't have any numbers, it's just that in this case the rwsem feels > more correct. My opinion is not very strong so you can apply v2.
Like I say the semaphore in particular feels wrong when we don't need the counting, we have an explicit reader/writer lock if that's what you're trying to accomplish. [unhandled content-type:application/pgp-signature] | |