Messages in this thread | | | Date | Fri, 6 Jan 2023 16:26:23 +0000 | From | Mark Brown <> | Subject | Re: [PATCH 3/5] spi: Use a 32-bit DT property for spi-cs-setup-delay-ns |
| |
On Wed, Jan 04, 2023 at 06:36:29PM +0900, Janne Grunau wrote:
> 65us is not a reasonable maximum for this property, as some devices > might need a much longer setup time (e.g. those driven by firmware on > the other end). Plus, device tree property values are in 32-bit cells > and smaller widths should not be used without good reason.
This breaks allmodconfig builds (I tested x86 but this should happen for anything with -Werror):
/build/stage/linux/drivers/spi/spi.c: In function ‘of_spi_parse_dt’: /build/stage/linux/drivers/spi/spi.c:2243:13: error: unused variable ‘cs_setup’ [-Werror=unused-variable] 2243 | u16 cs_setup; | ^~~~~~~~ cc1: all warnings being treated as errors [unhandled content-type:application/pgp-signature] | |