lkml.org 
[lkml]   [2023]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 net-next 1/3] net: dsa: mv88e6xxx: change default return of mv88e6xxx_port_bridge_flags
    Date
    The default return value -EOPNOTSUPP of mv88e6xxx_port_bridge_flags()
    came from the return value of the DSA method port_egress_floods() in
    commit 4f85901f0063 ("net: dsa: mv88e6xxx: add support for bridge flags"),
    but the DSA API was changed in commit a8b659e7ff75 ("net: dsa: act as
    passthrough for bridge port flags"), resulting in the return value
    -EOPNOTSUPP not being valid anymore, and sections for new flags will not
    need to set the return value to zero on success, as with the new mab flag
    added in a following patch.

    Signed-off-by: Hans J. Schultz <netdev@kapio-technology.com>
    ---
    drivers/net/dsa/mv88e6xxx/chip.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
    index 242b8b325504..29d4ff8e1181 100644
    --- a/drivers/net/dsa/mv88e6xxx/chip.c
    +++ b/drivers/net/dsa/mv88e6xxx/chip.c
    @@ -6545,7 +6545,7 @@ static int mv88e6xxx_port_bridge_flags(struct dsa_switch *ds, int port,
    struct netlink_ext_ack *extack)
    {
    struct mv88e6xxx_chip *chip = ds->priv;
    - int err = -EOPNOTSUPP;
    + int err = 0;

    mv88e6xxx_reg_lock(chip);

    --
    2.34.1
    \
     
     \ /
      Last update: 2023-03-26 23:31    [W:3.388 / U:0.516 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site