Messages in this thread | | | Date | Fri, 6 Jan 2023 09:20:20 +0100 | From | Corentin Labbe <> | Subject | Re: [PATCH v2 1/3] dt-bindings: crypto: sun8i-ce: Add compatible for D1 |
| |
Le Sat, Dec 31, 2022 at 04:01:43PM -0600, Samuel Holland a écrit : > D1 has a crypto engine similar to the one in other Allwinner SoCs. > Like H6, it has a separate MBUS clock gate. > > It also requires the internal RC oscillator to be enabled for the TRNG > to return data, presumably because noise from the oscillator is used as > an entropy source. This is likely the case for earlier variants as well, > but it really only matters for H616 and newer SoCs, as H6 provides no > way to disable the internal oscillator. > > Signed-off-by: Samuel Holland <samuel@sholland.org> > --- > I noticed that the vendor driver has code to explicitly enable IOSC when > using the TRNG on A83T (search SS_TRNG_OSC_ADDR), but that is covered by > a different binding/driver in mainline. > > Changes in v2: > - Add TRNG clock > > .../bindings/crypto/allwinner,sun8i-ce.yaml | 33 ++++++++++++++----- > 1 file changed, 25 insertions(+), 8 deletions(-) >
Acked-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Thanks
| |