Messages in this thread | | | Date | Thu, 5 Jan 2023 10:17:25 +0100 | From | Neil Armstrong <> | Subject | Re: [PATCH 2/2] drm/panel: add visionox vtdr6130 DSI panel driver |
| |
Hi,
On 04/01/2023 19:25, Rayyan Ansari wrote: > Hello, > I am not a maintainer, but I thought I might give a few comments.
Any comment is always welcome !
> > On 03/01/2023 14:22, Neil Armstrong wrote: >> Add support for the 1080x2400 Visionox VTDR6130 AMOLED DSI panel >> found on the Qualcomm SM8550 MTP board. >> >> By default the the panel is configured to work with DSI compressed >> streams, but can work in uncompressed video mode since 1080x2400 in >> RGB888 fits in the 4 DSI lanes bandwidth. >> >> While display compression is preferred for performance and power >> reasons, let's start with the uncompressed video mode support and >> add the DSC support later on. >> >> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> >> --- >> drivers/gpu/drm/panel/Kconfig | 8 + >> drivers/gpu/drm/panel/Makefile | 1 + >> drivers/gpu/drm/panel/panel-visionox-vtdr6130.c | 366 ++++++++++++++++++++++++ >> 3 files changed, 375 insertions(+) >>
<snip>
>> + >> +MODULE_AUTHOR("Neil Armstron <neil.armstrong@linaro.org>"); > > Missed a "g" here :-) > >> +MODULE_DESCRIPTION("Panel driver for the visionox VTDR6130 AMOLED DSI panel"); > > I am not sure how the company capitalises the name, but to keep it consistent with the other mentions, I think it should be "Visionox".
Thanks, I'll fix these.
Neil
> >> +MODULE_LICENSE("GPL"); >> >
| |