lkml.org 
[lkml]   [2023]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v6 07/18] dt-bindings: display/msm: Add list of mdss-dsi-ctrl compats
From
On 04/01/2023 02:29, Rob Herring wrote:
> On Fri, Dec 23, 2022 at 02:10:14AM +0000, Bryan O'Donoghue wrote:
>> Add the list of current compats absent the deprecated qcm2290 to the list
>> of dsi compats listed here.
>>
>> Several MDSS yaml files exist which document the dsi sub-node.
>> For each existing SoC MDSS yaml, provide the right dsi compat string.
>>
>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>> ---
>> .../bindings/display/msm/qcom,mdss.yaml | 16 +++++++++++++++-
>> .../bindings/display/msm/qcom,msm8998-mdss.yaml | 8 +++++---
>> .../bindings/display/msm/qcom,sc7180-mdss.yaml | 6 ++++--
>> .../bindings/display/msm/qcom,sc7280-mdss.yaml | 6 ++++--
>> .../bindings/display/msm/qcom,sdm845-mdss.yaml | 8 +++++---
>> .../bindings/display/msm/qcom,sm8250-mdss.yaml | 8 +++++---
>> 6 files changed, 38 insertions(+), 14 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,mdss.yaml
>> index ba0460268731b..86bb43489bf4a 100644
>> --- a/Documentation/devicetree/bindings/display/msm/qcom,mdss.yaml
>> +++ b/Documentation/devicetree/bindings/display/msm/qcom,mdss.yaml
>> @@ -94,7 +94,21 @@ patternProperties:
>> type: object
>> properties:
>> compatible:
>> - const: qcom,mdss-dsi-ctrl
>> + items:
>> + - enum:
>> + - qcom,apq8064-dsi-ctrl
>> + - qcom,msm8916-dsi-ctrl
>> + - qcom,msm8953-dsi-ctrl
>> + - qcom,msm8974-dsi-ctrl
>> + - qcom,msm8996-dsi-ctrl
>> + - qcom,msm8998-dsi-ctrl
>> + - qcom,qcm2290-dsi-ctrl
>> + - qcom,sc7180-dsi-ctrl
>> + - qcom,sc7280-dsi-ctrl
>> + - qcom,sdm660-dsi-ctrl
>> + - qcom,sdm845-dsi-ctrl
>> + - qcom,sm8250-dsi-ctrl
>> + - const: qcom,mdss-dsi-ctrl
>
> No need to have an exact match here. Just this is enough:
>
> compatible:
> contains:
> const: qcom,mdss-dsi-ctrl
>
> Then the DSI schema will check the rest.

I think the intent here should have been to list DSI variants usable
with the qcom,mdss device. But then the list should be shortened a bit.
E.g. apq8064 is pre-MDSS and sc7180/7280 and sm8250 are used with
qcom,SoC-mdss devices rather than just qcom,mdss.

> Same for the rest.
>
> Rob

--
With best wishes
Dmitry

\
 
 \ /
  Last update: 2023-03-26 23:26    [W:0.063 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site