Messages in this thread | | | Date | Tue, 31 Jan 2023 18:52:17 +0900 | Subject | Re: [PATCH v2 (repost)] locking/lockdep: add debug_show_all_lock_holders() | From | Tetsuo Handa <> |
| |
Ingo, what do you think?
I want your tree to send this patch in the upcoming merge window.
On 2023/01/17 12:28, Waiman Long wrote: >> Please talk with Waiman. I'm fine with either approach. > > My original concern was that two functions are very similar with some minor difference. My suggestion was to use a common helper to reduce the code redundancy and future maintenance. > > I do have some nits about the patch. The show_stack parameter isn't informative. Maybe you can use show_tasks as the parameter name since the major difference is the calling of sched_show_task(). > > Define a new helper like debug_show_all_locks_tasks(bool show_tasks), use it directly in check_hung_uninterruptible_tasks() and make debug_show_all_lock() call debug_show_all_locks_tasks(). > > Ingo, will that OK with you? > > Cheers, > Longman >
| |