lkml.org 
[lkml]   [2023]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH-next v2 2/2] scsi: fix iscsi rescan fails to create block device
From
Date
Hi,

在 2023/01/30 1:30, James Bottomley 写道:
> On Sat, 2023-01-28 at 17:41 +0800, Zhong Jinghua wrote:
>> This error will cause a warning:
>> kobject_add_internal failed for block (error: -2 parent: 1:0:0:1).
>> In the lower version (such as 5.10), there is no corresponding error
>> handling, continuing
>> to go down will trigger a kernel panic, so cc stable.
>
> Is this is important point and what you're saying is that this only
> panics on kernels before 5.10 or so because after that it's correctly
> failed by block device error handling so there's nothing to fix in
> later kernels?
>
> In that case, isn't the correct fix to look at backporting the block
> device error handling:

This is the last commit that support error handling, and there are many
relied patches, and there are lots of refactor in block layer. It's not
a good idea to backport error handling to lower version.

Althrough error handling can prevent kernel crash in this case, I still
think it make sense to make sure kobject is deleted in order, parent
should not be deleted before child.

Thanks,
Kuai
>
> commit 83cbce9574462c6b4eed6797bdaf18fae6859ab3
> Author: Luis Chamberlain <mcgrof@kernel.org>
> Date: Wed Aug 18 16:45:40 2021 +0200
>
> block: add error handling for device_add_disk / add_disk
>
> ?
>
> James
>
> .
>

\
 
 \ /
  Last update: 2023-03-27 00:01    [W:0.124 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site