Messages in this thread | | | Subject | Re: [PATCH v4 7/7] clk: qcom: add the driver for the MSM8996 APCS clocks | From | Stephen Boyd <> | Date | Fri, 27 Jan 2023 13:24:31 -0800 |
| |
Quoting Dmitry Baryshkov (2023-01-26 14:51:51) > On 25/01/2023 23:38, Stephen Boyd wrote: > > Quoting Dmitry Baryshkov (2023-01-18 05:22:54) > >> diff --git a/drivers/clk/qcom/apcs-msm8996.c b/drivers/clk/qcom/apcs-msm8996.c > >> new file mode 100644 > >> index 000000000000..7e46ea8ed444 > >> --- /dev/null > >> +++ b/drivers/clk/qcom/apcs-msm8996.c > >> @@ -0,0 +1,76 @@ > >> + > >> + /* > >> + * Register the clock as fixed rate instead of being a child of gpll0 > >> + * to let the driver register probe as early as possible. > > > > The function doesn't block or return EPROBE_DEFER if the clk is orphaned > > when registered. Why is this necessary? Are you getting defered by the > > fw_devlink logic thinking it needs to defer probe of this driver until > > gpll0 provider probes? We should fix fw_devlink to not do that. Maybe if > > the node is a clk provider (#clock-cells exists) then we don't wait for > > clocks property to be provided, because the clk core already handles > > that itself. > > Letting clock-controllers probe was my idea for the patch, but it was > delayed again by Saravana, see [1], [2]
Ah, I didn't see it because linux-clk wasn't Cced and I look at that mail pile less regularly.
| |