Messages in this thread | | | From | Ian Rogers <> | Date | Tue, 24 Jan 2023 09:47:50 -0800 | Subject | Re: [PATCH v8 1/9] perf pmu: Add #slots literal support for arm64 |
| |
On Wed, Jan 18, 2023 at 7:54 PM Jing Zhang <renyu.zj@linux.alibaba.com> wrote: > > > > 在 2023/1/17 下午4:45, John Garry 写道: > > On 17/01/2023 07:29, Jing Zhang wrote: > >> The slots in each architecture may be different, so add #slots literal > >> to obtain the slots of different architectures, and the #slots can be > >> applied in the metric. Currently, The #slots just support for arm64, > >> and other architectures will return NAN. > >> > >> On arm64, the value of slots is from the register PMMIR_EL1.SLOT, which > >> I can read in /sys/bus/event_source/device/armv8_pmuv3_*/caps/slots. > >> PMMIR_EL1.SLOT might read as zero if the PMU version is lower than > >> ID_AA64DFR0_EL1_PMUVer_V3P4 or the STALL_SLOT event is not implemented. > >> > >> Signed-off-by: Jing Zhang<renyu.zj@linux.alibaba.com> > > > > Reviewed-by: John Garry <john.g.garry@oracle.com> > > Hi Ian, > > Do you think there are other problems with this patch? Can I get your tags? > > Thanks, > Jing
Sorry for not seeing this earlier, I see it is already in Arnaldo's tree: https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/commit/?h=perf/core&id=acef233b7ca749fda153a06bbd2d9feb2bb16857
Thanks, Ian
| |