Messages in this thread | | | Date | Mon, 23 Jan 2023 22:30:33 -0800 | From | Jakub Kicinski <> | Subject | Re: [PATCH v4 net-next 04/12] net: ethtool: netlink: retrieve stats from multiple sources (eMAC, pMAC) |
| |
On Tue, 24 Jan 2023 07:20:20 +0100 Eric Dumazet wrote: > > static int pause_prepare_data(const struct ethnl_req_info *req_base, > > struct ethnl_reply_data *reply_base, > > struct genl_info *info) > > { > > + const struct pause_req_info *req_info = PAUSE_REQINFO(req_base); > > struct pause_reply_data *data = PAUSE_REPDATA(reply_base); > > + enum ethtool_mac_stats_src src = req_info->src; > > + struct netlink_ext_ack *extack = info->extack; > > info can be NULL when called from ethnl_default_dump_one()
Second time in a month, I think..
Should we make a fake info to pass here? (until someone finds the time to combine the do/dump infos more thoroughly, at least)
| |