Messages in this thread | | | Date | Tue, 24 Jan 2023 11:10:45 +0100 | Subject | Re: [PATCH] drm/ssd130x: Silence a `dubious: x & !y` warning | From | Javier Martinez Canillas <> |
| |
On 1/21/23 20:09, Javier Martinez Canillas wrote: > The sparse tool complains with the following warning: > > $ make M=drivers/gpu/drm/solomon/ C=2 > CC [M] drivers/gpu/drm/solomon/ssd130x.o > CHECK drivers/gpu/drm/solomon/ssd130x.c > drivers/gpu/drm/solomon/ssd130x.c:363:21: warning: dubious: x & !y > > This seems to be a false positive in my opinion but still we can silence > the tool while making the code easier to read. Let's also add a comment, > to explain why the "com_seq" logical not is used rather than its value. > > Reported-by: Thomas Zimmermann <tzimmermann@suse.de> > Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> > Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> > --- >
Pushed this to drm-misc (drm-misc-next). Thanks!
-- Best regards,
Javier Martinez Canillas Core Platforms Red Hat
| |