lkml.org 
[lkml]   [2023]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] firmware: arm_scmi: Clean up a return statement
On Mon, Jan 23, 2023 at 06:07:07PM +0300, Dan Carpenter wrote:
> The comments say "enabled" where "disabled" is intended. Also it's
> cleaner to return zero explicitly instead of ret.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---
> drivers/firmware/arm_scmi/driver.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c
> index d21c7eafd641..703f16ef3953 100644
> --- a/drivers/firmware/arm_scmi/driver.c
> +++ b/drivers/firmware/arm_scmi/driver.c
> @@ -2739,8 +2739,8 @@ static int scmi_probe(struct platform_device *pdev)
> if (ret)
> goto clear_dev_req_notifier;
>
> - /* Bail out anyway when coex enabled */
> - return ret;
> + /* Bail out anyway when coex disabled. */
> + return 0;
> }
>
> /* Coex enabled, carry on in any case. */
> --

Indeed.

Thanks,
Cristian

\
 
 \ /
  Last update: 2023-03-26 23:53    [W:0.088 / U:1.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site