Messages in this thread | | | Date | Tue, 24 Jan 2023 09:46:01 +0100 | Subject | Re: [PATCH v2 4/4] ASoC: dt-bindings: ti,ts3a227e.yaml: add jack-type | From | Astrid Rost <> |
| |
Hello Rob,
On 1/23/23 23:09, Rob Herring wrote: > On Fri, Jan 20, 2023 at 11:25:54AM +0100, Astrid Rost wrote: >> Add jack-type: Bitmap value of snd_jack_type to allow combining >> card drivers to create a jack for it. >> >> Signed-off-by: Astrid Rost <astrid.rost@axis.com> >> --- >> Documentation/devicetree/bindings/sound/ti,ts3a227e.yaml | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/sound/ti,ts3a227e.yaml b/Documentation/devicetree/bindings/sound/ti,ts3a227e.yaml >> index 785930658029..1d949b805f98 100644 >> --- a/Documentation/devicetree/bindings/sound/ti,ts3a227e.yaml >> +++ b/Documentation/devicetree/bindings/sound/ti,ts3a227e.yaml >> @@ -27,6 +27,14 @@ properties: >> interrupts: >> maxItems: 1 >> >> + jack-type: >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + description: Bitmap value of snd_jack_type to allow combining > > snd_jack_type? Is that a Linux thing? Bindings are independent of Linux. > >> + card drivers to create a jack for it. Supported is >> + 1 SND_JACK_HEADPHONE >> + 2 SND_JACK_MICROPHONE >> + default: 3 > > I'm pretty sure jack properties are more complicated than just headphone > and/or microphone. There's buttons which are detected in differing ways.
Yes, you are right. On the buttons, someone would like to have an keymapping like KEY_VOLUMEDOWN, KEY_VOLUMEUP for the different buttons SND_JACK_BTN_X. This is always added to the jack by the ts3a227e driver.
I pushed yesterday a v3, which returns all supported jack types by this device. I am happy with this.
> > Rob
Best regards
Astrid
| |