Messages in this thread | | | Date | Tue, 24 Jan 2023 16:27:43 +0800 | From | Li Chen <> | Subject | Re: [PATCH 06/15] soc: add Ambarella driver |
| |
On Mon, 23 Jan 2023 19:48:42 +0800,
Hi Conor.Dooley
<Conor.Dooley@microchip.com> wrote: > > Hey Li Chen, > > Since you've already got a bunch of other comments, I have > two minor ones for you. > > On 23/01/2023 07:32, Li Chen wrote: > > > > This driver add soc_id support for Ambarella, > > which is stored inside "cpuid" AXI address mapping. > > > > Also provide sys_config(POC, aka power on configuration) > > for other drivers. > > > > Signed-off-by: Li Chen <lchen@ambarella.com> > > Change-Id: I4869a3497366ac7779e792835f8e0309239036a8 > > --- > > > diff --git a/drivers/soc/Makefile b/drivers/soc/Makefile > > index fff513bd522d..e3e270aa32a4 100644 > > --- a/drivers/soc/Makefile > > +++ b/drivers/soc/Makefile > > @@ -8,6 +8,7 @@ obj-y += apple/ > > obj-y += aspeed/ > > obj-$(CONFIG_ARCH_AT91) += atmel/ > > obj-y += bcm/ > > +obj-$(CONFIG_ARCH_AMBARELLA) += ambarella/ > > obj-$(CONFIG_SOC_CANAAN) += canaan/ > > If you could follow the existing (by directory) alphabetical > order that'd be great.
Well noted. I will fix it in v2.
> > obj-$(CONFIG_ARCH_DOVE) += dove/ > > obj-$(CONFIG_MACH_DOVE) += dove/ > > diff --git a/drivers/soc/ambarella/Makefile b/drivers/soc/ambarella/Makefile > > new file mode 100644 > > index 000000000000..384276c046ca > > --- /dev/null > > +++ b/drivers/soc/ambarella/Makefile > > @@ -0,0 +1,3 @@ > > +# SPDX-License-Identifier: GPL-2.0-only > > + > > +obj-$(CONFIG_ARCH_AMBARELLA) += soc.o > > The subdirectory is already gated by this symbol, so is there much point > gating it on the same one again?
Yeah, it lookgs kind of redundant now, but I will upstream other drivers after this series get merged, which are not gated by this symbol.
Regards, Li
| |