lkml.org 
[lkml]   [2023]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v1] KVM: destruct kvm_io_device while unregistering it from kvm_io_bus
Date
On Tuesday, January 24, 2023 7:25 AM, Sean Christopherson wrote:
> > - kfree(bus);
> > - return new_bus ? 0 : -ENOMEM;
> > + kvm_iodevice_destructor(dev);
> > + return 0;
>
> Unless I'm misreading things, this path leaks "bus".

Right, should keep the kfree above.

> Given that that intent is to send the fix for stable, that this is as much a
> cleanup as it is a bug fix, and that it's not super trivial, I'm inclined to queue
> my patch and then land this on top as cleanup.

Sounds good to me.
\
 
 \ /
  Last update: 2023-01-25 03:38    [W:0.085 / U:2.700 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site