Messages in this thread | | | Subject | Re: [PATCH v4 24/24] integrity/powerpc: Support loading keys from pseries secvar | From | Andrew Donnellan <> | Date | Wed, 25 Jan 2023 11:45:08 +1100 |
| |
On Tue, 2023-01-24 at 10:14 -0500, Mimi Zohar wrote: > > - /* The following only applies for the edk2-compat backend. > > */ > > - node = of_find_compatible_node(NULL, NULL, "ibm,edk2- > > compat-v1"); > > - if (!node) > > + len = secvar_ops->format(buf, 32); > > "powerpc/secvar: Handle format string in the consumer" defines > opal_secvar_format() for the object format "ibm,secvar-backend". > Here > shouldn't it being returning the format for "ibm,edk2-compat-v1"?
opal_secvar_format() doesn't return "ibm,secvar-backend", it searches for the device tree node named "ibm,secvar-backend", then reads and returns the contents of the property "format" under that node.
The expected content of the format property is "ibm,edk2-compat-v1".
-- Andrew Donnellan OzLabs, ADL Canberra ajd@linux.ibm.com IBM Australia Limited
| |