lkml.org 
[lkml]   [2023]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH net-next v8 1/8] bnxt_en: Add auxiliary driver support
On Mon, Jan 23, 2023 at 10:53 PM Leon Romanovsky <leon@kernel.org> wrote:
>
> On Mon, Jan 23, 2023 at 10:33:05PM -0800, Jakub Kicinski wrote:
> > On Thu, 19 Jan 2023 22:05:28 -0800 Ajit Khaparde wrote:
> > > @@ -13212,6 +13214,7 @@ static void bnxt_remove_one(struct pci_dev *pdev)
> > > kfree(bp->rss_indir_tbl);
> > > bp->rss_indir_tbl = NULL;
> > > bnxt_free_port_stats(bp);
> > > + bnxt_aux_priv_free(bp);
> > > free_netdev(dev);
> >
> > You're still freeing the memory in which struct device sits regardless
> > of its reference count.
>
> BTW, Ajit does the same wrong kfree in bnxt_rdma_aux_device_add() too.
I will address this in the next version. Thanks again.

Thanks
Ajit
> + ret = auxiliary_device_add(aux_dev);
> + if (ret)
> + goto aux_dev_uninit;
> +
> ...
> +aux_dev_uninit:
> + auxiliary_device_uninit(aux_dev);
> +free_edev:
> + kfree(edev); <----- wrong
> + bp->edev = NULL;
>
> Thanks
[unhandled content-type:application/pkcs7-signature]
\
 
 \ /
  Last update: 2023-03-26 23:53    [W:0.089 / U:0.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site