lkml.org 
[lkml]   [2023]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/8] eventfs: introducing struct tracefs_inode
    Hi Ajay,

    Thank you for the patch! Perhaps something to improve:

    [auto build test WARNING on linus/master]
    [also build test WARNING on v6.2-rc5]
    [If your patch is applied to the wrong git tree, kindly drop us a note.
    And when submitting patch, we suggest to use '--base' as documented in
    https://git-scm.com/docs/git-format-patch#_base_tree_information]

    url: https://github.com/intel-lab-lkp/linux/commits/Ajay-Kaher/eventfs-adding-eventfs-dir-add-functions/20230123-010956
    patch link: https://lore.kernel.org/r/1674407228-49109-1-git-send-email-akaher%40vmware.com
    patch subject: [PATCH 1/8] eventfs: introducing struct tracefs_inode
    config: x86_64-rhel-8.3-rust (https://download.01.org/0day-ci/archive/20230123/202301231320.vExYuIWP-lkp@intel.com/config)
    compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
    reproduce (this is a W=1 build):
    wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
    chmod +x ~/bin/make.cross
    # https://github.com/intel-lab-lkp/linux/commit/926ba0e4029baa4bbc7c283854148d1769642d50
    git remote add linux-review https://github.com/intel-lab-lkp/linux
    git fetch --no-tags linux-review Ajay-Kaher/eventfs-adding-eventfs-dir-add-functions/20230123-010956
    git checkout 926ba0e4029baa4bbc7c283854148d1769642d50
    # save the config file
    mkdir build_dir && cp config build_dir/.config
    COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 olddefconfig
    COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash fs/tracefs/

    If you fix the issue, kindly add following tag where applicable
    | Reported-by: kernel test robot <lkp@intel.com>

    All warnings (new ones prefixed by >>):

    >> fs/tracefs/inode.c:130:15: warning: no previous prototype for function 'tracefs_get_inode' [-Wmissing-prototypes]
    struct inode *tracefs_get_inode(struct super_block *sb)
    ^
    fs/tracefs/inode.c:130:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
    struct inode *tracefs_get_inode(struct super_block *sb)
    ^
    static
    >> fs/tracefs/inode.c:402:16: warning: no previous prototype for function 'tracefs_start_creating' [-Wmissing-prototypes]
    struct dentry *tracefs_start_creating(const char *name, struct dentry *parent)
    ^
    fs/tracefs/inode.c:402:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
    struct dentry *tracefs_start_creating(const char *name, struct dentry *parent)
    ^
    static
    >> fs/tracefs/inode.c:440:16: warning: no previous prototype for function 'tracefs_failed_creating' [-Wmissing-prototypes]
    struct dentry *tracefs_failed_creating(struct dentry *dentry)
    ^
    fs/tracefs/inode.c:440:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
    struct dentry *tracefs_failed_creating(struct dentry *dentry)
    ^
    static
    >> fs/tracefs/inode.c:448:16: warning: no previous prototype for function 'tracefs_end_creating' [-Wmissing-prototypes]
    struct dentry *tracefs_end_creating(struct dentry *dentry)
    ^
    fs/tracefs/inode.c:448:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
    struct dentry *tracefs_end_creating(struct dentry *dentry)
    ^
    static
    4 warnings generated.


    vim +/tracefs_get_inode +130 fs/tracefs/inode.c

    129
    > 130 struct inode *tracefs_get_inode(struct super_block *sb)
    131 {
    132 struct inode *inode = new_inode(sb);
    133 if (inode) {
    134 inode->i_ino = get_next_ino();
    135 inode->i_atime = inode->i_mtime = inode->i_ctime = current_time(inode);
    136 }
    137 return inode;
    138 }
    139

    --
    0-DAY CI Kernel Test Service
    https://github.com/intel/lkp-tests

    \
     
     \ /
      Last update: 2023-03-26 23:52    [W:4.092 / U:0.260 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site