lkml.org 
[lkml]   [2023]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 2/2] soundwire: bus: Remove unused reset_page_addr() callback
    Date
    A previous patch removed unnecessary zeroing of the page registers
    after a paged transaction, so now the reset_page_addr callback is
    unused and can be removed.

    Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
    Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
    ---
    drivers/soundwire/cadence_master.c | 14 --------------
    drivers/soundwire/cadence_master.h | 3 ---
    drivers/soundwire/intel_auxdevice.c | 1 -
    include/linux/soundwire/sdw.h | 3 ---
    4 files changed, 21 deletions(-)

    diff --git a/drivers/soundwire/cadence_master.c b/drivers/soundwire/cadence_master.c
    index 521387322145..f44e8f9a1c09 100644
    --- a/drivers/soundwire/cadence_master.c
    +++ b/drivers/soundwire/cadence_master.c
    @@ -770,20 +770,6 @@ cdns_xfer_msg_defer(struct sdw_bus *bus,
    }
    EXPORT_SYMBOL(cdns_xfer_msg_defer);

    -enum sdw_command_response
    -cdns_reset_page_addr(struct sdw_bus *bus, unsigned int dev_num)
    -{
    - struct sdw_cdns *cdns = bus_to_cdns(bus);
    - struct sdw_msg msg;
    -
    - /* Create dummy message with valid device number */
    - memset(&msg, 0, sizeof(msg));
    - msg.dev_num = dev_num;
    -
    - return cdns_program_scp_addr(cdns, &msg);
    -}
    -EXPORT_SYMBOL(cdns_reset_page_addr);
    -
    u32 cdns_read_ping_status(struct sdw_bus *bus)
    {
    struct sdw_cdns *cdns = bus_to_cdns(bus);
    diff --git a/drivers/soundwire/cadence_master.h b/drivers/soundwire/cadence_master.h
    index fa9dc38264a4..2efc857d21aa 100644
    --- a/drivers/soundwire/cadence_master.h
    +++ b/drivers/soundwire/cadence_master.h
    @@ -182,9 +182,6 @@ struct sdw_cdns_pdi *sdw_cdns_alloc_pdi(struct sdw_cdns *cdns,
    void sdw_cdns_config_stream(struct sdw_cdns *cdns,
    u32 ch, u32 dir, struct sdw_cdns_pdi *pdi);

    -enum sdw_command_response
    -cdns_reset_page_addr(struct sdw_bus *bus, unsigned int dev_num);
    -
    enum sdw_command_response
    cdns_xfer_msg(struct sdw_bus *bus, struct sdw_msg *msg);

    diff --git a/drivers/soundwire/intel_auxdevice.c b/drivers/soundwire/intel_auxdevice.c
    index 96c6b2112feb..5021be0f4158 100644
    --- a/drivers/soundwire/intel_auxdevice.c
    +++ b/drivers/soundwire/intel_auxdevice.c
    @@ -113,7 +113,6 @@ static struct sdw_master_ops sdw_intel_ops = {
    .override_adr = sdw_dmi_override_adr,
    .xfer_msg = cdns_xfer_msg,
    .xfer_msg_defer = cdns_xfer_msg_defer,
    - .reset_page_addr = cdns_reset_page_addr,
    .set_bus_conf = cdns_bus_conf,
    .pre_bank_switch = generic_pre_bank_switch,
    .post_bank_switch = generic_post_bank_switch,
    diff --git a/include/linux/soundwire/sdw.h b/include/linux/soundwire/sdw.h
    index 3cd2a761911f..a8d74635ea0d 100644
    --- a/include/linux/soundwire/sdw.h
    +++ b/include/linux/soundwire/sdw.h
    @@ -838,7 +838,6 @@ struct sdw_defer {
    * @override_adr: Override value read from firmware (quirk for buggy firmware)
    * @xfer_msg: Transfer message callback
    * @xfer_msg_defer: Defer version of transfer message callback
    - * @reset_page_addr: Reset the SCP page address registers
    * @set_bus_conf: Set the bus configuration
    * @pre_bank_switch: Callback for pre bank switch
    * @post_bank_switch: Callback for post bank switch
    @@ -854,8 +853,6 @@ struct sdw_master_ops {
    enum sdw_command_response (*xfer_msg_defer)
    (struct sdw_bus *bus, struct sdw_msg *msg,
    struct sdw_defer *defer);
    - enum sdw_command_response (*reset_page_addr)
    - (struct sdw_bus *bus, unsigned int dev_num);
    int (*set_bus_conf)(struct sdw_bus *bus,
    struct sdw_bus_params *params);
    int (*pre_bank_switch)(struct sdw_bus *bus);
    --
    2.30.2
    \
     
     \ /
      Last update: 2023-03-26 23:52    [W:2.696 / U:0.312 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site