lkml.org 
[lkml]   [2023]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v3 1/5] i2c: hpe: Add GXP SoC I2C Controller
Date

> The i2c core calls disable_irq for us (see i2c_device_shutdown) so you
> don't need that here.


> In my review I wondered if you needed to do something like this:


> + regmap_update_bits(i2cg_map, GXP_I2CINTEN, 0x00000FFF, 0);

Thank you for pointing this out. I will correct this for the next patch set.

-Nick Hawkins


\
 
 \ /
  Last update: 2023-03-26 23:52    [W:0.082 / U:0.880 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site