Messages in this thread | | | From | "Hawkins, Nick" <> | Subject | Re: [PATCH v3 1/5] i2c: hpe: Add GXP SoC I2C Controller | Date | Mon, 23 Jan 2023 15:41:30 +0000 |
| |
> The i2c core calls disable_irq for us (see i2c_device_shutdown) so you > don't need that here.
> In my review I wondered if you needed to do something like this:
> + regmap_update_bits(i2cg_map, GXP_I2CINTEN, 0x00000FFF, 0);
Thank you for pointing this out. I will correct this for the next patch set.
-Nick Hawkins
| |