lkml.org 
[lkml]   [2023]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v7 6/8] block: Make bio structs pin pages rather than ref'ing if appropriate
On Mon, Jan 23, 2023 at 11:28:40AM +0000, David Howells wrote:
> void __bio_release_pages(struct bio *bio, bool mark_dirty)
> {
> unsigned int gup_flags = bio_to_gup_flags(bio);
> struct bvec_iter_all iter_all;
> struct bio_vec *bvec;
>
> bio_for_each_segment_all(bvec, bio, iter_all) {
> if (mark_dirty && !PageCompound(bvec->bv_page))
> set_page_dirty_lock(bvec->bv_page);
> >>>> page_put_unpin(bvec->bv_page, gup_flags);
> }
> }
>
> that ought to be a call to bio_release_page(), but the optimiser doesn't want
> to inline it:-/

Why? __bio_release_pages is the fast path, no need to force using
bio_relese_page which is otherwise only used for error cleanup.

\
 
 \ /
  Last update: 2023-03-26 23:52    [W:0.131 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site