Messages in this thread | | | Date | Mon, 23 Jan 2023 10:36:36 +0000 | Subject | Re: [PATCH v5 2/8] perf: Use perf_pmu__open_file() and perf_pmu__scan_file() | From | James Clark <> |
| |
On 20/01/2023 17:43, Arnaldo Carvalho de Melo wrote: > Em Fri, Jan 20, 2023 at 02:32:30PM -0300, Arnaldo Carvalho de Melo escreveu: >> Em Fri, Jan 20, 2023 at 02:21:56PM -0300, Arnaldo Carvalho de Melo escreveu: >>> Em Fri, Jan 20, 2023 at 02:36:55PM +0000, James Clark escreveu: >>>> Remove some code that duplicates existing methods. Copy strings where >>>> const strings are required. >>>> >>>> No functional changes. >>> >>> >>> Have you used 'perf test'? >>> >>> [acme@quaco perf]$ perf test -v python >>> Couldn't bump rlimit(MEMLOCK), failures may take place when creating BPF maps, etc >>> 19: 'import perf' in python : >>> --- start --- >>> test child forked, pid 232379 >>> python usage test: "echo "import sys ; sys.path.append('/tmp/build/perf/python'); import perf" | '/usr/bin/python3' " >>> Traceback (most recent call last): >>> File "<stdin>", line 1, in <module> >>> ImportError: /tmp/build/perf/python/perf.cpython-310-x86_64-linux-gnu.so: undefined symbol: perf_pmu__scan_file >>> test child finished with -1 >>> ---- end ---- >>> 'import perf' in python: FAILED! >>> [acme@quaco perf]$ >> >> I added this to this cset, now it passes. > > So, what I have is now at my tmp.perf/core branch, pending container > testing, later today probably will move to perf/core, so that it gets > exposure on linux-next for v6.3. >
Gah! Sorry, I must have only run the Coresight tests. I will make sure all the tests are passing on my setup so it's easier to spot next time.
Thanks for the fix.
| |