Messages in this thread |  | | From | Rob Herring <> | | Subject | Re: [PATCH 11/13] dt-bindings: serial: restrict possible child node names | | Date | Mon, 23 Jan 2023 17:05:40 -0600 |
| |
On Mon, 23 Jan 2023 16:13:00 +0100, Krzysztof Kozlowski wrote: > The re-usable serial.yaml schema matches every property with ".*" > pattern, thus any other schema referencing it will not report unknown > (unevaluated) properties. This hides several wrong properties. It is > a limitation of dtschema, thus provide a simple workaround: expect > children to be only of few names matching upstream usage (Bluetooth, > GNSS, GPS and MCU). > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > Documentation/devicetree/bindings/serial/serial.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/bus/intel,ixp4xx-expansion-bus-controller.example.dtb: serial@1,0: Unevaluated properties are not allowed ('intel,ixp4xx-eb-byte-access', 'intel,ixp4xx-eb-cycle-type', 'intel,ixp4xx-eb-t3', 'intel,ixp4xx-eb-write-enable' were unexpected) From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/serial/8250.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230123151302.368277-11-krzysztof.kozlowski@linaro.org
The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
|  |