lkml.org 
[lkml]   [2023]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/1] iio: adc: qcom-spmi-adc5: Fix the channel name
On Mon, 23 Jan 2023 14:02:51 +0200
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> On Sun, Jan 22, 2023 at 05:24:41PM +0000, Jonathan Cameron wrote:
> > On Wed, 18 Jan 2023 12:06:23 +0200
> > Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> >
> > > The node name can contain an address part which is unused
> > > by the driver. Moreover, this string is propagated into
> > > the userspace label, sysfs filenames *and breaking ABI*.
> > >
> > > Cut the address part out before assigning the channel name.
> > >
> > > Fixes: 4f47a236a23d ("iio: adc: qcom-spmi-adc5: convert to device properties")
> > > Reported-by: Marijn Suijten <marijn.suijten@somainline.org>
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >
> > LGTM, but given it will have ABI impact, I'd like to hear from
> > Andy, Bjorn or Konrad as maintainers and /or Dmitry as someone
> > who has touched this driver fairly recently.
>
> Hmm... But this is to fix the ABI breakage. It means that the previous series
> by Nuno had broken it.
Absolutely agree. I plan to take the change. The risk that someone needs
to fix up their use of the broken ABI makes it worth a little more shouting
about than if we had caught it sooner.

Jonathan

>
> > Mostly I want to be sure they know this exists before it causes surprise.
>

\
 
 \ /
  Last update: 2023-03-26 23:53    [W:0.724 / U:0.868 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site