Messages in this thread | | | Date | Mon, 23 Jan 2023 13:10:45 +0800 | From | kernel test robot <> | Subject | Re: [PATCH v2] thermal: int340x_thermal: Add production mode attribute |
| |
Hi Srinivas,
I love your patch! Perhaps something to improve:
[auto build test WARNING on rafael-pm/thermal] [also build test WARNING on linus/master v6.2-rc5] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Srinivas-Pandruvada/thermal-int340x_thermal-Add-production-mode-attribute/20230123-104105 base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git thermal patch link: https://lore.kernel.org/r/20230123024040.337866-1-srinivas.pandruvada%40linux.intel.com patch subject: [PATCH v2] thermal: int340x_thermal: Add production mode attribute config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20230123/202301231218.inlZXxdA-lkp@intel.com/config) compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/2c4e5f536a8e523a9f48701629806ecb63346cc0 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Srinivas-Pandruvada/thermal-int340x_thermal-Add-production-mode-attribute/20230123-104105 git checkout 2c4e5f536a8e523a9f48701629806ecb63346cc0 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=x86_64 olddefconfig make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/thermal/intel/int340x_thermal/
If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/thermal/intel/int340x_thermal/int3400_thermal.c:351:6: warning: no previous prototype for 'production_mode_exit' [-Wmissing-prototypes] 351 | void production_mode_exit(struct int3400_thermal_priv *priv) | ^~~~~~~~~~~~~~~~~~~~
vim +/production_mode_exit +351 drivers/thermal/intel/int340x_thermal/int3400_thermal.c
350 > 351 void production_mode_exit(struct int3400_thermal_priv *priv) 352 { 353 if (priv->production_mode >= 0) 354 sysfs_remove_file(&priv->pdev->dev.kobj, &dev_attr_production_mode.attr); 355 } 356
-- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
| |