lkml.org 
[lkml]   [2023]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] nfsd: don't free files unconditionally in __nfsd_file_cache_purge
Date


> On Jan 22, 2023, at 9:58 AM, Shachar Kagan <skagan@nvidia.com> wrote:
>
>
> On Sun, 2023-01-22 at 16:58 +0000, Shachar Kagan wrote:
>
>> On Sat, 2023-01-21 at 17:04 +0000, Chuck Lever III wrote:
>>>
>>>> On Jan 20, 2023, at 3:54 PM, Jeff Layton <jlayton@kernel.org> wrote:
>>>>
>>>> On Fri, 2023-01-20 at 20:21 +0000, Chuck Lever III wrote:
>>>>>
>>>>>> On Jan 20, 2023, at 2:52 PM, Jeff Layton <jlayton@kernel.org> wrote:
>>>>>>
>>>>>> nfsd_file_cache_purge is called when the server is shutting
>>>>>> down, in which case, tearing things down is generally fine, but
>>>>>> it also gets called when the exports cache is flushed.
>>>>>
>>>>> Yeah... cache flush is probably the case we've been missing.
>>>>>
>>>>>
>>>>>> Instead of walking the cache and freeing everything
>>>>>> unconditionally, handle it the same as when we have a notification of conflicting access.
>>>>>>
>>>>>> Fixes: ac3a2585f018 ("nfsd: rework refcounting in filecache")
>>>>>> Reported-by: Ruben Vestergaard <rubenv@drcmr.dk>
>>>>>> Reported-by: Torkil Svensgaard <torkil@drcmr.dk>
>>>>>> Reported-by: Shachar Kagan <skagan@nvidia.com>
>>>>>> Signed-off-by: Jeff Layton <jlayton@kernel.org>
>
> I ran our tests with the commit, the issue didn't occur.
> Thanks for the quick response.

May I add Tested-by: Shachar Kagan <skagan@nvidia.com> ?

--
Chuck Lever



\
 
 \ /
  Last update: 2023-03-26 23:51    [W:0.115 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site