lkml.org 
[lkml]   [2023]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v5 5/6] clk: qcom: lpassaudiocc-sc7280: Merge lpasscc into lpass_aon
    Hi Srinivasa,

    Thank you for the patch! Yet something to improve:

    [auto build test ERROR on clk/clk-next]
    [also build test ERROR on linus/master v6.2-rc4 next-20230120]
    [If your patch is applied to the wrong git tree, kindly drop us a note.
    And when submitting patch, we suggest to use '--base' as documented in
    https://git-scm.com/docs/git-format-patch#_base_tree_information]

    url: https://github.com/intel-lab-lkp/linux/commits/Srinivasa-Rao-Mandadapu/dt-bindings-clock-qcom-sc7280-lpasscc-Add-qcom-adsp-pil-mode-property/20230120-204835
    base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
    patch link: https://lore.kernel.org/r/1674218806-7711-6-git-send-email-quic_srivasam%40quicinc.com
    patch subject: [PATCH v5 5/6] clk: qcom: lpassaudiocc-sc7280: Merge lpasscc into lpass_aon
    config: arm-randconfig-r006-20230119 (https://download.01.org/0day-ci/archive/20230121/202301211545.p4v6zuaX-lkp@intel.com/config)
    compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 4196ca3278f78c6e19246e54ab0ecb364e37d66a)
    reproduce (this is a W=1 build):
    wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
    chmod +x ~/bin/make.cross
    # install arm cross compiling tool for clang build
    # apt-get install binutils-arm-linux-gnueabi
    # https://github.com/intel-lab-lkp/linux/commit/9163f9ad677af61b97b9ea5ef569722f277a7d20
    git remote add linux-review https://github.com/intel-lab-lkp/linux
    git fetch --no-tags linux-review Srinivasa-Rao-Mandadapu/dt-bindings-clock-qcom-sc7280-lpasscc-Add-qcom-adsp-pil-mode-property/20230120-204835
    git checkout 9163f9ad677af61b97b9ea5ef569722f277a7d20
    # save the config file
    mkdir build_dir && cp config build_dir/.config
    COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm olddefconfig
    COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/clk/qcom/

    If you fix the issue, kindly add following tag where applicable
    | Reported-by: kernel test robot <lkp@intel.com>

    All errors (new ones prefixed by >>):

    >> drivers/clk/qcom/lpassaudiocc-sc7280.c:831:3: error: use of undeclared identifier 'res'; did you mean 'ret'?
    res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "cc");
    ^~~
    ret
    drivers/clk/qcom/lpassaudiocc-sc7280.c:824:6: note: 'ret' declared here
    int ret;
    ^
    >> drivers/clk/qcom/lpassaudiocc-sc7280.c:831:7: error: incompatible pointer to integer conversion assigning to 'int' from 'struct resource *' [-Wint-conversion]
    res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "cc");
    ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    drivers/clk/qcom/lpassaudiocc-sc7280.c:832:7: error: use of undeclared identifier 'res'; did you mean 'ret'?
    if (res) {
    ^~~
    ret
    drivers/clk/qcom/lpassaudiocc-sc7280.c:824:6: note: 'ret' declared here
    int ret;
    ^
    3 errors generated.


    vim +831 drivers/clk/qcom/lpassaudiocc-sc7280.c

    819
    820 static int lpass_aon_cc_sc7280_probe(struct platform_device *pdev)
    821 {
    822 const struct qcom_cc_desc *desc;
    823 struct regmap *regmap;
    824 int ret;
    825
    826 ret = lpass_audio_setup_runtime_pm(pdev);
    827 if (ret)
    828 return ret;
    829
    830 if (of_property_read_bool(pdev->dev.of_node, "qcom,adsp-pil-mode")) {
    > 831 res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "cc");
    832 if (res) {
    833 lpass_audio_cc_sc7280_regmap_config.name = "cc";
    834 desc = &lpass_cc_sc7280_desc;
    835 return qcom_cc_probe(pdev, desc);
    836 }
    837 }
    838
    839 lpass_audio_cc_sc7280_regmap_config.name = "lpasscc_aon";
    840 lpass_audio_cc_sc7280_regmap_config.max_register = 0xa0008;
    841 desc = &lpass_aon_cc_sc7280_desc;
    842
    843 regmap = qcom_cc_map(pdev, desc);
    844 if (IS_ERR(regmap)) {
    845 ret = PTR_ERR(regmap);
    846 goto exit;
    847 }
    848
    849 clk_lucid_pll_configure(&lpass_aon_cc_pll, regmap, &lpass_aon_cc_pll_config);
    850
    851 ret = qcom_cc_really_probe(pdev, &lpass_aon_cc_sc7280_desc, regmap);
    852 if (ret) {
    853 dev_err(&pdev->dev, "Failed to register LPASS AON CC clocks\n");
    854 goto exit;
    855 }
    856
    857 pm_runtime_mark_last_busy(&pdev->dev);
    858 exit:
    859 pm_runtime_put_autosuspend(&pdev->dev);
    860
    861 return ret;
    862 }
    863

    --
    0-DAY CI Kernel Test Service
    https://github.com/intel/lkp-tests

    \
     
     \ /
      Last update: 2023-03-26 23:51    [W:2.349 / U:0.208 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site