Messages in this thread | | | From | Lukasz Stelmach <> | Subject | Re: [PATCH v2 03/13] net: Replace all spi->chip_select and spi->cs_gpiod references with function call | Date | Fri, 20 Jan 2023 11:30:01 +0100 |
| |
It was <2023-01-20 pią 00:23>, when Amit Kumar Mahapatra wrote: > Supporting multi-cs in spi drivers would require the chip_select & cs_gpiod > members of struct spi_device to be an array. But changing the type of these > members to array would break the spi driver functionality. To make the > transition smoother introduced four new APIs to get/set the > spi->chip_select & spi->cs_gpiod and replaced all spi->chip_select and > spi->cs_gpiod references with get or set API calls. > While adding multi-cs support in further patches the chip_select & cs_gpiod > members of the spi_device structure would be converted to arrays & the > "idx" parameter of the APIs would be used as array index i.e., > spi->chip_select[idx] & spi->cs_gpiod[idx] respectively. > > Signed-off-by: Amit Kumar Mahapatra <amit.kumar-mahapatra@amd.com> > --- > drivers/net/ethernet/adi/adin1110.c | 2 +- > drivers/net/ethernet/asix/ax88796c_main.c | 2 +- > drivers/net/ethernet/davicom/dm9051.c | 2 +- > drivers/net/ethernet/qualcomm/qca_debug.c | 2 +- > drivers/net/ieee802154/ca8210.c | 2 +- > drivers/net/wan/slic_ds26522.c | 2 +- > drivers/net/wireless/marvell/libertas/if_spi.c | 2 +- > drivers/net/wireless/silabs/wfx/bus_spi.c | 2 +- > drivers/net/wireless/st/cw1200/cw1200_spi.c | 2 +- > 9 files changed, 9 insertions(+), 9 deletions(-) >
Acked-by: Łukasz Stelmach <l.stelmach@samsung.com>
[...]
> diff --git a/drivers/net/ethernet/asix/ax88796c_main.c b/drivers/net/ethernet/asix/ax88796c_main.c > index 21376c79f671..e551ffaed20d 100644 > --- a/drivers/net/ethernet/asix/ax88796c_main.c > +++ b/drivers/net/ethernet/asix/ax88796c_main.c > @@ -1006,7 +1006,7 @@ static int ax88796c_probe(struct spi_device *spi) > ax_local->mdiobus->parent = &spi->dev; > > snprintf(ax_local->mdiobus->id, MII_BUS_ID_SIZE, > - "ax88796c-%s.%u", dev_name(&spi->dev), spi->chip_select); > + "ax88796c-%s.%u", dev_name(&spi->dev), spi_get_chipselect(spi, 0)); > > ret = devm_mdiobus_register(&spi->dev, ax_local->mdiobus); > if (ret < 0) {
[...]
-- Łukasz Stelmach Samsung R&D Institute Poland Samsung Electronics [unhandled content-type:application/pgp-signature] | |