lkml.org 
[lkml]   [2023]   [Jan]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 00/14] drm/panel: Make panel drivers use existing DSI write macros
    From
    On 1/2/23 20:00, Sam Ravnborg wrote:
    > Hi Javier.
    >
    > On Wed, Dec 28, 2022 at 02:47:43AM +0100, Javier Martinez Canillas wrote:
    >> Hello,
    >>
    >> This series contains cleanups for DRM panel drivers that define their own
    >> DSI write macros instead of using what's already in <drm/drm_mipi_dsi.h>.
    >>
    >> The changes are quite trivial but I've only tested this with allmodconfig
    >> and `make M=drivers/gpu/drm/panel/` so please review and testing would be
    >> highly appreciated.
    >
    > Nice cleanup - I like it.

    Thanks.

    > In most of the patches there is some trivial indent that should be
    > fixed, I think I noted it everywhere.
    >

    Yup, I just used sed -i to modify in-place but the new macro _seq suffix
    caused the wrong indent everywhere. I'll fix them in v2.

    > Sorry - but no testing.
    >

    No worries, I also just build tested the drivers since I lack the HW but
    the changes are pretty trivial so I expect no functional changes.

    > The last patch is buggy - see the comment.

    Indeed. Thanks for pointing that out! I completely missed that the macro
    was different than the others.

    > I suggest to land patch 1 now (with the fix), this makes it easier for
    > others to test on top of drm-misc-next.
    >

    Agreed. I'll just post that one as a v2 and then the rest as a separate
    series after pushing that to drm-misc-next.

    --
    Best regards,

    Javier Martinez Canillas
    Core Platforms
    Red Hat

    \
     
     \ /
      Last update: 2023-03-26 23:25    [W:4.219 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site