Messages in this thread | | | From | "G, GurucharanX" <> | Subject | RE: [Intel-wired-lan] [PATCH] net/i40e: Replace 0-length array with flexible array | Date | Thu, 19 Jan 2023 09:46:50 +0000 |
| |
> -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of > Kees Cook > Sent: Friday, January 6, 2023 5:16 AM > To: Brandeburg, Jesse <jesse.brandeburg@intel.com> > Cc: Kees Cook <keescook@chromium.org>; intel-wired-lan@lists.osuosl.org; > Gustavo A. R. Silva <gustavoars@kernel.org>; linux-kernel@vger.kernel.org; > Eric Dumazet <edumazet@google.com>; Nguyen, Anthony L > <anthony.l.nguyen@intel.com>; linux-hardening@vger.kernel.org; > netdev@vger.kernel.org; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni > <pabeni@redhat.com>; David S. Miller <davem@davemloft.net> > Subject: [Intel-wired-lan] [PATCH] net/i40e: Replace 0-length array with > flexible array > > Zero-length arrays are deprecated[1]. Replace struct i40e_lump_tracking's > "list" 0-length array with a flexible array. Detected with GCC 13, using -fstrict- > flex-arrays=3: > > In function 'i40e_put_lump', > inlined from 'i40e_clear_interrupt_scheme' at > drivers/net/ethernet/intel/i40e/i40e_main.c:5145:2: > drivers/net/ethernet/intel/i40e/i40e_main.c:278:27: warning: array subscript > <unknown> is outside array bounds of 'u16[0]' {aka 'short unsigned int[]'} [- > Warray-bounds=] > 278 | pile->list[i] = 0; > | ~~~~~~~~~~^~~ > drivers/net/ethernet/intel/i40e/i40e.h: In function > 'i40e_clear_interrupt_scheme': > drivers/net/ethernet/intel/i40e/i40e.h:179:13: note: while referencing 'list' > 179 | u16 list[0]; > | ^~~~ > > [1] > https://www.kernel.org/doc/html/latest/process/deprecated.html#zero- > length-and-one-element-arrays > > Cc: Jesse Brandeburg <jesse.brandeburg@intel.com> > Cc: Tony Nguyen <anthony.l.nguyen@intel.com> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Eric Dumazet <edumazet@google.com> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: Paolo Abeni <pabeni@redhat.com> > Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org> > Cc: intel-wired-lan@lists.osuosl.org > Cc: netdev@vger.kernel.org > Signed-off-by: Kees Cook <keescook@chromium.org> > --- > drivers/net/ethernet/intel/i40e/i40e.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >
Tested-by: Gurucharan G <gurucharanx.g@intel.com> (A Contingent worker at Intel)
| |