Messages in this thread | | | Date | Thu, 19 Jan 2023 10:28:47 -0800 | Subject | Re: [PATCH 6/9] ice: Remove redundant pci_enable_pcie_error_reporting() | From | Tony Nguyen <> |
| |
On 1/18/2023 3:46 PM, Bjorn Helgaas wrote: > From: Bjorn Helgaas <bhelgaas@google.com> > > pci_enable_pcie_error_reporting() enables the device to send ERR_* > Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is > native"), the PCI core does this for all devices during enumeration. > > Remove the redundant pci_enable_pcie_error_reporting() call from the > driver. Also remove the corresponding pci_disable_pcie_error_reporting() > from the driver .remove() path. > > Note that this doesn't control interrupt generation by the Root Port; that > is controlled by the AER Root Error Command register, which is managed by > the AER service driver. > > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> > Cc: Jesse Brandeburg <jesse.brandeburg@intel.com> > Cc: Tony Nguyen <anthony.l.nguyen@intel.com> > Cc: intel-wired-lan@lists.osuosl.org > Cc: netdev@vger.kernel.org > --- > drivers/net/ethernet/intel/ice/ice_main.c | 3 --- > 1 file changed, 3 deletions(-)
Reviewed-by: Tony Nguyen <anthony.l.nguyen@intel.com>
> diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c > index a9a7f8b52140..9fb68919df02 100644 > --- a/drivers/net/ethernet/intel/ice/ice_main.c > +++ b/drivers/net/ethernet/intel/ice/ice_main.c > @@ -4672,7 +4672,6 @@ ice_probe(struct pci_dev *pdev, const struct pci_device_id __always_unused *ent) > return err; > } > > - pci_enable_pcie_error_reporting(pdev); > pci_set_master(pdev); > > pf->pdev = pdev; > @@ -4975,7 +4974,6 @@ ice_probe(struct pci_dev *pdev, const struct pci_device_id __always_unused *ent) > ice_devlink_destroy_regions(pf); > ice_deinit_hw(hw); > err_exit_unroll: > - pci_disable_pcie_error_reporting(pdev); > pci_disable_device(pdev); > return err; > } > @@ -5103,7 +5101,6 @@ static void ice_remove(struct pci_dev *pdev) > ice_reset(&pf->hw, ICE_RESET_PFR); > pci_wait_for_pending_transaction(pdev); > ice_clear_interrupt_scheme(pf); > - pci_disable_pcie_error_reporting(pdev); > pci_disable_device(pdev); > } >
| |