lkml.org 
[lkml]   [2023]   [Jan]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v9 02/15] dt-bindings: mmc: cdns: Add AMD Pensando Elba SoC
From
On 19/01/2023 04:51, Brad Larson wrote:
> AMD Pensando Elba ARM 64-bit SoC is integrated with this IP and
> explicitly controls byte-lane enables.
>
> Signed-off-by: Brad Larson <blarson@amd.com>
>
> ---
>
> Changes since v6:
> - Add reset-names and resets properties
> - Add if/then on property amd,pensando-elba-sd4hc to set reg property
> values for minItems and maxItems
>
> ---
> .../devicetree/bindings/mmc/cdns,sdhci.yaml | 28 ++++++++++++++++++-
> 1 file changed, 27 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml b/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
> index 8b1a0fdcb5e3..f7dd6f990f96 100644
> --- a/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
> +++ b/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
> @@ -16,12 +16,14 @@ properties:
> compatible:
> items:
> - enum:
> + - amd,pensando-elba-sd4hc
> - microchip,mpfs-sd4hc
> - socionext,uniphier-sd4hc
> - const: cdns,sd4hc
>
> reg:
> - maxItems: 1
> + minItems: 1
> + maxItems: 2
>
> interrupts:
> maxItems: 1
> @@ -111,12 +113,36 @@ properties:
> minimum: 0
> maximum: 0x7f
>
> + reset-names:
> + items:
> + - const: hw
> +
> + resets:
> + description:
> + optional. phandle to the system reset controller with line index
> + for mmc hw reset line if exists.
> + maxItems: 1
> +
> required:
> - compatible
> - reg
> - interrupts
> - clocks
>
> +if:
> + properties:
> + compatible:
> + const: amd,pensando-elba-sd4hc

BTW, this probably won't even work and that's the answer why you added
fake maxItems: 2... This should make you think about the bug. You must
use contains.

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2023-03-26 23:47    [W:0.246 / U:0.636 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site