lkml.org 
[lkml]   [2023]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v11 04/11] cpufreq: amd-pstate: implement Pstate EPP support for the AMD processors
    Hi Perry,

    I love your patch! Perhaps something to improve:

    [auto build test WARNING on rafael-pm/linux-next]
    [also build test WARNING on linus/master v6.2-rc4 next-20230118]
    [If your patch is applied to the wrong git tree, kindly drop us a note.
    And when submitting patch, we suggest to use '--base' as documented in
    https://git-scm.com/docs/git-format-patch#_base_tree_information]

    url: https://github.com/intel-lab-lkp/linux/commits/Perry-Yuan/ACPI-CPPC-Add-AMD-pstate-energy-performance-preference-cppc-control/20230118-163633
    base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
    patch link: https://lore.kernel.org/r/20230118075210.447418-5-perry.yuan%40amd.com
    patch subject: [PATCH v11 04/11] cpufreq: amd-pstate: implement Pstate EPP support for the AMD processors
    config: x86_64-randconfig-a013-20230116 (https://download.01.org/0day-ci/archive/20230118/202301182325.NoodiJ0K-lkp@intel.com/config)
    compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
    reproduce (this is a W=1 build):
    # https://github.com/intel-lab-lkp/linux/commit/d596b3586a809f4f6b65ec216c168b6f01c82f67
    git remote add linux-review https://github.com/intel-lab-lkp/linux
    git fetch --no-tags linux-review Perry-Yuan/ACPI-CPPC-Add-AMD-pstate-energy-performance-preference-cppc-control/20230118-163633
    git checkout d596b3586a809f4f6b65ec216c168b6f01c82f67
    # save the config file
    mkdir build_dir && cp config build_dir/.config
    make W=1 O=build_dir ARCH=x86_64 olddefconfig
    make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/cpufreq/

    If you fix the issue, kindly add following tag where applicable
    | Reported-by: kernel test robot <lkp@intel.com>

    All warnings (new ones prefixed by >>):

    In file included from drivers/cpufreq/amd-pstate-ut.c:29:
    >> include/linux/amd-pstate.h:142:21: warning: 'epp_values' defined but not used [-Wunused-variable]
    142 | static unsigned int epp_values[] = {
    | ^~~~~~~~~~
    >> include/linux/amd-pstate.h:133:27: warning: 'energy_perf_strings' defined but not used [-Wunused-const-variable=]
    133 | static const char * const energy_perf_strings[] = {
    | ^~~~~~~~~~~~~~~~~~~
    include/linux/amd-pstate.h:97:27: warning: 'amd_pstate_mode_string' defined but not used [-Wunused-const-variable=]
    97 | static const char * const amd_pstate_mode_string[] = {
    | ^~~~~~~~~~~~~~~~~~~~~~


    vim +/epp_values +142 include/linux/amd-pstate.h

    132
    > 133 static const char * const energy_perf_strings[] = {
    134 [EPP_INDEX_DEFAULT] = "default",
    135 [EPP_INDEX_PERFORMANCE] = "performance",
    136 [EPP_INDEX_BALANCE_PERFORMANCE] = "balance_performance",
    137 [EPP_INDEX_BALANCE_POWERSAVE] = "balance_power",
    138 [EPP_INDEX_POWERSAVE] = "power",
    139 NULL
    140 };
    141
    > 142 static unsigned int epp_values[] = {

    --
    0-DAY CI Kernel Test Service
    https://github.com/intel/lkp-tests

    \
     
     \ /
      Last update: 2023-03-26 23:46    [W:5.110 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site