lkml.org 
[lkml]   [2023]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v4 16/17] arm64: dts: freescale: apalis-imx8: fix reserved-memory node names
    From
    On 18/01/2023 15:36, Marcel Ziswiler wrote:
    > On Wed, 2023-01-18 at 15:02 +0100, Krzysztof Kozlowski wrote:
    >> On 18/01/2023 08:26, Marcel Ziswiler wrote:
    >>> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
    >>>
    >>> Fix reserved-memory node names using dashes rather than underscores.
    >>>
    >>> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
    >>>
    >>> ---
    >>>
    >>> Changes in v4:
    >>> - New patch fixing reserved-memory node names.
    >>>
    >>>  arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi | 12 ++++++------
    >>>  1 file changed, 6 insertions(+), 6 deletions(-)
    >>>
    >>> diff --git a/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi b/arch/arm64/boot/dts/freescale/imx8-
    >>> apalis-v1.1.dtsi
    >>> index 70c00b92cb05..6217e0a48f96 100644
    >>> --- a/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi
    >>> +++ b/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi
    >>> @@ -133,17 +133,17 @@ reserved-memory {
    >>>                 #size-cells = <2>;
    >>>                 ranges;
    >>>  
    >>> -               decoder_boot: decoder_boot@84000000 {
    >>> +               decoder_boot: decoder-boot@84000000 {
    >>
    >> This is ridiculous. You just added it! If we consider original code as
    >> wrong, then you intentionally added wrong code just to fix it.
    >>
    >> No, that's not the way how it should be developed.
    >
    > Shawn asked me to ease the review process which is exactly what I did.

    Any reason why b4 diff cannot be used? If your patchset fails b4
    auto-detection of version, this should be fixed instead of fake split.

    Best regards,
    Krzysztof

    \
     
     \ /
      Last update: 2023-03-26 23:46    [W:4.477 / U:0.456 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site