lkml.org 
[lkml]   [2023]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v4 12/17] arm64: dts: freescale: apalis-imx8: analogue audio comment
Date
On Wed, 2023-01-18 at 14:59 +0100, Krzysztof Kozlowski wrote:
> On 18/01/2023 08:26, Marcel Ziswiler wrote:
> > From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> >
> > Added a comment about Apalis analogue audio being another todo.
> >
> > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> You just added this file in previous patch. This should be squashed
> instead of splitting one logical change (adding new hardware) into
> multiple independent patches.

Remember, I explicitly did that for review purpose and even mentioned this in the cover letter.

> Best regards,
> Krzysztof
\
 
 \ /
  Last update: 2023-03-26 23:46    [W:0.080 / U:0.556 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site