lkml.org 
[lkml]   [2023]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH rdma-next 00/13] Add RDMA inline crypto support
From
Hi Eric,

On 1/18/2023 8:47 AM, Eric Biggers wrote:
> Hi Leon,
>
> On Mon, Jan 16, 2023 at 03:05:47PM +0200, Leon Romanovsky wrote:
>> >From Israel,
>>
>> The purpose of this patchset is to add support for inline
>> encryption/decryption of the data at storage protocols like nvmf over
>> RDMA (at a similar way like integrity is used via unique mkey).
>>
>> This patchset adds support for plaintext keys. The patches were tested
>> on BF-3 HW with fscrypt tool to test this feature, which showed reduce
>> in CPU utilization when comparing at 64k or more IO size. The CPU utilization
>> was improved by more than 50% comparing to the SW only solution at this case.
>>
>> How to configure fscrypt to enable plaintext keys:
>> # mkfs.ext4 -O encrypt /dev/nvme0n1
>> # mount /dev/nvme0n1 /mnt/crypto -o inlinecrypt
>> # head -c 64 /dev/urandom > /tmp/master_key
>> # fscryptctl add_key /mnt/crypto/ < /tmp/master_key
>> # mkdir /mnt/crypto/test1
>> # fscryptctl set_policy 152c41b2ea39fa3d90ea06448456e7fb /mnt/crypto/test1
>> ** “152c41b2ea39fa3d90ea06448456e7fb” is the output of the
>> “fscryptctl add_key” command.
>> # echo foo > /mnt/crypto/test1/foo
>>
>> Notes:
>> - At plaintext mode only, the user set a master key and the fscrypt
>> driver derived from it the DEK and the key identifier.
>> - 152c41b2ea39fa3d90ea06448456e7fb is the derived key identifier
>> - Only on the first IO, nvme-rdma gets a callback to load the derived DEK.
>>
>> There is no special configuration to support crypto at nvme modules.
>>
>> Thanks
> Very interesting work! Can you Cc me on future versions?
>
> I'm glad to see that this hardware allows all 16 IV bytes to be specified.
>
> Does it also handle programming and evicting keys efficiently?
>
> Also, just checking: have you tested that the ciphertext that this inline
> encryption hardware produces is correct? That's always super important to test.
> There are xfstests that test for it, e.g. generic/582. Another way to test it
> is to just manually test whether encrypted files that were created when the
> filesystem was mounted with '-o inlinecrypt' show the same contents when the
> filesystem is *not* mounted with '-o inlinecrypt' (or vice versa).
sure, I ran the manual test of comparing the encrypted files content
with and without the '-o inlinecrypt' at the mount command.
>
> - Eric
 - Israel

\
 
 \ /
  Last update: 2023-03-26 23:45    [W:0.226 / U:26.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site