lkml.org 
[lkml]   [2023]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH net-next v3 0/2] Fix CPTS release action in am65-cpts driver
From
On 1/18/2023 1:54 AM, Siddharth Vadapalli wrote:
> Delete unreachable code in am65_cpsw_init_cpts() function, which was
> Reported-by: Leon Romanovsky <leon@kernel.org>
> at:
> https://lore.kernel.org/r/Y8aHwSnVK9+sAb24@unreal
>
> Remove the devm action associated with am65_cpts_release() and invoke the
> function directly on the cleanup and exit paths.
>
> Changes from v2:
> 1. Drop Reviewed-by tag from Roger Quadros.
> 2. Add cleanup patch for deleting unreachable error handling code in
> am65_cpsw_init_cpts().
> 3. Drop am65_cpsw_cpts_cleanup() function and directly invoke
> am65_cpts_release().
>
> Changes from v1:
> 1. Fix the build issue when "CONFIG_TI_K3_AM65_CPTS" is not set. This
> error was reported by kernel test robot <lkp@intel.com> at:
> https://lore.kernel.org/r/202301142105.lt733Lt3-lkp@intel.com/
> 2. Collect Reviewed-by tag from Roger Quadros.
>
> v2:
> https://lore.kernel.org/r/20230116044517.310461-1-s-vadapalli@ti.com/
> v1:
> https://lore.kernel.org/r/20230113104816.132815-1-s-vadapalli@ti.com/
>
> Siddharth Vadapalli (2):
> net: ethernet: ti: am65-cpsw: Delete unreachable error handling code
> net: ethernet: ti: am65-cpsw/cpts: Fix CPTS release action
>
> drivers/net/ethernet/ti/am65-cpsw-nuss.c | 7 ++-----
> drivers/net/ethernet/ti/am65-cpts.c | 15 +++++----------
> drivers/net/ethernet/ti/am65-cpts.h | 5 +++++
> 3 files changed, 12 insertions(+), 15 deletions(-)

Seems reasonable to me.

Reviewed-by: Tony Nguyen <anthony.l.nguyen@intel.com>

\
 
 \ /
  Last update: 2023-03-26 23:46    [W:0.118 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site