lkml.org 
[lkml]   [2023]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/2] gpiolib: acpi: Add a ignore wakeup quirk for Clevo NL5xRU
    On Mon, Jan 16, 2023 at 01:37:02PM -0600, Mario Limonciello wrote:
    > commit 1796f808e4bb ("HID: i2c-hid: acpi: Stop setting wakeup_capable")
    > changed the policy such that I2C touchpads may be able to wake up the
    > system by default if the system is configured as such.
    >
    > However on Clevo NL5xRU there is a mistake in the ACPI tables that the
    > TP_ATTN# signal connected to GPIO 9 is configured as ActiveLow and level
    > triggered but connected to a pull up. As soon as the system suspends the
    > touchpad loses power and then the system wakes up.
    >
    > To avoid this problem, introduce a quirk for this model that will prevent
    > the wakeup capability for being set for GPIO 9.

    Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

    > Fixes: 1796f808e4bb ("HID: i2c-hid: acpi: Stop setting wakeup_capable")
    > Reported-by: Werner Sembach <wse@tuxedocomputers.com>
    > Link: https://gitlab.freedesktop.org/drm/amd/-/issues/1722#note_1720627
    > Co-developed-by: Werner Sembach <wse@tuxedocomputers.com>
    > Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
    > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
    > ---
    > drivers/gpio/gpiolib-acpi.c | 13 +++++++++++++
    > 1 file changed, 13 insertions(+)
    >
    > diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
    > index 4287555a12408..9ef0f5641b521 100644
    > --- a/drivers/gpio/gpiolib-acpi.c
    > +++ b/drivers/gpio/gpiolib-acpi.c
    > @@ -1623,6 +1623,19 @@ static const struct dmi_system_id gpiolib_acpi_quirks[] __initconst = {
    > .ignore_interrupt = "AMDI0030:00@18",
    > },
    > },
    > + {
    > + /*
    > + * Spurious wakeups from TP_ATTN# pin
    > + * Found in BIOS 1.7.8
    > + * https://gitlab.freedesktop.org/drm/amd/-/issues/1722#note_1720627
    > + */
    > + .matches = {
    > + DMI_MATCH(DMI_BOARD_NAME, "NL5xRU"),
    > + },
    > + .driver_data = &(struct acpi_gpiolib_dmi_quirk) {
    > + .ignore_wake = "ELAN0415:00@9",
    > + },
    > + },
    > {} /* Terminating entry */
    > };
    >
    > --
    > 2.34.1
    >

    --
    With Best Regards,
    Andy Shevchenko


    \
     
     \ /
      Last update: 2023-03-26 23:43    [W:3.194 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site