Messages in this thread | | | Date | Mon, 16 Jan 2023 09:11:30 +0100 | Subject | Re: [RESEND v3 02/13] arm64: dts: mediatek: mt8195: add MDP3 nodes | From | Krzysztof Kozlowski <> |
| |
On 16/01/2023 04:21, Moudy Ho wrote: > Add device nodes for Media Data Path 3 (MDP3) modules. > > Signed-off-by: Moudy Ho <moudy.ho@mediatek.com> > --- > arch/arm64/boot/dts/mediatek/mt8195.dtsi | 420 +++++++++++++++++++++++ > 1 file changed, 420 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi > index 206dd534c3f6..d2d1ba71222d 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi > @@ -1706,6 +1706,133 @@ > #clock-cells = <1>; > }; > > + mdp3-rdma0@14001000 {
Node names should be generic. https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
0 is definitely not generic
Isn't this dma-controller? or if not then just rdma?
> + compatible = "mediatek,mt8195-mdp3-rdma"; > + reg = <0 0x14001000 0 0x1000>; > + mediatek,gce-client-reg = <&gce1 SUBSYS_1400XXXX 0x1000 0x1000>; > + mediatek,gce-events = <CMDQ_EVENT_VPP0_MDP_RDMA_SOF>, > + <CMDQ_EVENT_VPP0_MDP_RDMA_FRAME_DONE>; > + power-domains = <&spm MT8195_POWER_DOMAIN_VPPSYS0>, > + <&spm MT8195_POWER_DOMAIN_VPPSYS1>; > + iommus = <&iommu_vpp M4U_PORT_L4_MDP_RDMA>, > + <&iommu_vpp M4U_PORT_L4_MDP_WROT>; > + clocks = <&vppsys0 CLK_VPP0_MDP_RDMA>, > + <&topckgen CLK_TOP_CFG_VPP0>, > + <&topckgen CLK_TOP_CFG_26M_VPP0>, > + <&vppsys0 CLK_VPP0_WARP0_ASYNC_TX>, > + <&vppsys0 CLK_VPP0_WARP0_RELAY>, > + <&vppsys0 CLK_VPP0_WARP0_MDP_DL_ASYNC>, > + <&vppsys0 CLK_VPP0_WARP1_ASYNC_TX>, > + <&vppsys0 CLK_VPP0_WARP1_RELAY>, > + <&vppsys0 CLK_VPP0_WARP1_MDP_DL_ASYNC>, > + <&vppsys0 CLK_VPP0_VPP02VPP1_RELAY>, > + <&vppsys1 CLK_VPP1_DL_ASYNC>, > + <&vppsys1 CLK_VPP1_VPP0_DL_ASYNC>, > + <&vppsys1 CLK_VPP1_VPP0_DL_RELAY>, > + <&vppsys0 CLK_VPP0_VPP12VPP0_ASYNC>, > + <&vppsys1 CLK_VPP1_VPP0_DL1_RELAY>, > + <&vppsys1 CLK_VPP1_SVPP2_VDO0_DL_RELAY>, > + <&vppsys1 CLK_VPP1_SVPP3_VDO1_DL_RELAY>, > + <&vppsys1 CLK_VPP1_SVPP2_VDO1_DL_RELAY>, > + <&vppsys1 CLK_VPP1_SVPP3_VDO0_DL_RELAY>; > + mboxes = <&gce1 12 CMDQ_THR_PRIO_1>, > + <&gce1 13 CMDQ_THR_PRIO_1>, > + <&gce1 14 CMDQ_THR_PRIO_1>, > + <&gce1 21 CMDQ_THR_PRIO_1>, > + <&gce1 22 CMDQ_THR_PRIO_1>; > + }; > + > + mdp3-fg0@14002000 {
Node names should be generic. https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
"0" suffix is definitely nothing generic. Drop such suffixes everywhere. Drop also "mdp3" prefix everywhere.
Best regards, Krzysztof
| |