lkml.org 
[lkml]   [2023]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2] fs/aio: Replace kmap{,_atomic}() with kmap_local_page()
Date
Hi, Al,

Al Viro <viro@zeniv.linux.org.uk> writes:

> On Mon, Jan 09, 2023 at 06:56:29PM +0100, Fabio M. De Francesco wrote:
>
>> - ring = kmap_atomic(ctx->ring_pages[0]);
>> + ring = kmap_local_page(ctx->ring_pages[0]);
>> ring->nr = nr_events; /* user copy */
>> ring->id = ~0U;
>> ring->head = ring->tail = 0;
>> @@ -575,7 +575,7 @@ static int aio_setup_ring(struct kioctx *ctx, unsigned int nr_events)
>> ring->compat_features = AIO_RING_COMPAT_FEATURES;
>> ring->incompat_features = AIO_RING_INCOMPAT_FEATURES;
>> ring->header_length = sizeof(struct aio_ring);
>> - kunmap_atomic(ring);
>> + kunmap_local(ring);
>> flush_dcache_page(ctx->ring_pages[0]);
>
> I wonder if it would be more readable as memcpy_to_page(), actually...

I'm not sure I understand what you're suggesting.

>>
>> return 0;
>> @@ -678,9 +678,9 @@ static int ioctx_add_table(struct kioctx *ctx, struct mm_struct *mm)
>> * we are protected from page migration
>> * changes ring_pages by ->ring_lock.
>> */
>> - ring = kmap_atomic(ctx->ring_pages[0]);
>> + ring = kmap_local_page(ctx->ring_pages[0]);
>> ring->id = ctx->id;
>> - kunmap_atomic(ring);
>> + kunmap_local(ring);
>
> Incidentally, does it need flush_dcache_page()?

Yes, good catch.

Cheers,
Jeff

\
 
 \ /
  Last update: 2023-03-26 23:36    [W:0.077 / U:0.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site