Messages in this thread | | | Subject | Re: [PATCH 2/6] composefs: Add on-disk layout | From | Alexander Larsson <> | Date | Tue, 10 Jan 2023 17:19:25 +0100 |
| |
On Thu, 2023-01-05 at 10:55 -0500, Brian Masney wrote: > On Mon, Nov 28, 2022 at 12:16:23PM +0100, Alexander Larsson wrote: > > This commit adds the on-disk layout header file of composefs. > > > > Signed-off-by: Alexander Larsson <alexl@redhat.com> > > Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com> > > Add Co-Developed-By: Giuseppe ... ? > > Full disclosure: I'm not a file system developer but I'll attempt to > help with the review of this series. >
Thanks. I did various changes to the github repo based on your review, here are the outstanding comments:
> > > +struct cfs_header_s { > > + u8 version; > > + u8 unused1; > > + u16 unused2; > > + > > + u32 magic; > > Should the magic number appear first?
I don't think so, the version number is essentially part of the full magic string. >
> -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- =-=-= Alexander Larsson Red Hat, Inc alexl@redhat.com alexander.larsson@gmail.com He's a notorious vegetarian filmmaker who knows the secret of the alien invasion. She's an artistic tomboy nun married to the Mob. They fight crime!
| |