lkml.org 
[lkml]   [2023]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v6 04/18] dt-bindings: msm: dsi-controller-main: Add compatible strings for every current SoC
From
On 23/12/2022 04:10, Bryan O'Donoghue wrote:
> Currently we do not differentiate between the various users of the
> qcom,mdss-dsi-ctrl. The driver is flexible enough to operate from one
> compatible string but, the hardware does have some significant differences
> in the number of clocks.
>
> To facilitate documenting the clocks add the following compatible strings
>
> - qcom,apq8064-dsi-ctrl
> - qcom,msm8916-dsi-ctrl
> - qcom,msm8953-dsi-ctrl
> - qcom,msm8974-dsi-ctrl
> - qcom,msm8996-dsi-ctrl
> - qcom,msm8998-dsi-ctrl
> - qcom,sc7180-dsi-ctrl
> - qcom,sc7280-dsi-ctrl
> - qcom,sdm660-dsi-ctrl
> - qcom,sdm845-dsi-ctrl
> - qcom,sm8250-dsi-ctrl
> - qcom,qcm2290-dsi-ctrl
>
> Deprecate qcom,dsi-ctrl-6g-qcm2290 in favour of the desired format while we
> do so.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
> .../display/msm/dsi-controller-main.yaml | 26 ++++++++++++++++---
> 1 file changed, 22 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> index 6e2fd6e9fa7f0..98d54a7ee28d4 100644
> --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> @@ -14,9 +14,27 @@ allOf:
>
> properties:
> compatible:
> - enum:
> - - qcom,mdss-dsi-ctrl
> - - qcom,dsi-ctrl-6g-qcm2290
> + oneOf:
> + - items:
> + - enum:
> + - qcom,apq8064-dsi-ctrl
> + - qcom,msm8916-dsi-ctrl
> + - qcom,msm8953-dsi-ctrl
> + - qcom,msm8974-dsi-ctrl
> + - qcom,msm8996-dsi-ctrl
> + - qcom,msm8998-dsi-ctrl
> + - qcom,qcm2290-dsi-ctrl
> + - qcom,sc7180-dsi-ctrl
> + - qcom,sc7280-dsi-ctrl
> + - qcom,sdm660-dsi-ctrl
> + - qcom,sdm845-dsi-ctrl
> + - qcom,sm8250-dsi-ctrl

If you would for any reason send v7, could you please also add sm8150
and sm8[345]50?

> + - const: qcom,mdss-dsi-ctrl
> + - items:
> + - enum:
> + - dsi-ctrl-6g-qcm2290
> + - const: qcom,mdss-dsi-ctrl
> + deprecated: true
>
> reg:
> maxItems: 1
> @@ -149,7 +167,7 @@ examples:
> #include <dt-bindings/power/qcom-rpmpd.h>
>
> dsi@ae94000 {
> - compatible = "qcom,mdss-dsi-ctrl";
> + compatible = "qcom,sc7180-dsi-ctrl", "qcom,mdss-dsi-ctrl";
> reg = <0x0ae94000 0x400>;
> reg-names = "dsi_ctrl";
>

--
With best wishes
Dmitry

\
 
 \ /
  Last update: 2023-03-26 23:34    [W:0.182 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site